D23241: Show application window icon on AboutPage

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> caspermeijn wrote in settings.h:81
> I have no idea what the value would be for that and Kirigami doesn't have any example.

https://doc.qt.io/qt-5/qtqml-cppintegration-definetypes.html#type-revisions-and-versions

tldr:

- add `REVISON 10` to property
- change krigiamiplugin.cpp to register that revision

I am not sure how that would work for a singletontype though, one always needs all properties since any revision may be used at any time.
@apol are you sure this makes sense for singletons?

REPOSITORY
  R169 Kirigami

BRANCH
  about_icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23241

To: caspermeijn, mart, apol, #kirigami, hein
Cc: sitter, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190826/f636d29d/attachment-0001.html>