<table><tr><td style="">sitter added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23241">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23241#inline-132282">View Inline</a><span style="color: #4b4d51; font-weight: bold;">caspermeijn</span> wrote in <span style="color: #4b4d51; font-weight: bold;">settings.h:81</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I have no idea what the value would be for that and Kirigami doesn't have any example.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><a href="https://doc.qt.io/qt-5/qtqml-cppintegration-definetypes.html#type-revisions-and-versions" class="remarkup-link" target="_blank" rel="noreferrer">https://doc.qt.io/qt-5/qtqml-cppintegration-definetypes.html#type-revisions-and-versions</a></p>
<p style="padding: 0; margin: 8px;">tldr:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">add <tt style="background: #ebebeb; font-size: 13px;">REVISON 10</tt> to property</li>
<li class="remarkup-list-item">change krigiamiplugin.cpp to register that revision</li>
</ul>
<p style="padding: 0; margin: 8px;">I am not sure how that would work for a singletontype though, one always needs all properties since any revision may be used at any time.<br />
<a href="https://phabricator.kde.org/p/apol/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@apol</a> are you sure this makes sense for singletons?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><strong>BRANCH</strong><div><div>about_icon (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23241">https://phabricator.kde.org/D23241</a></div></div><br /><div><strong>To: </strong>caspermeijn, mart, apol, Kirigami, hein<br /><strong>Cc: </strong>sitter, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, davidedmundson, mart, hein<br /></div>