D23368: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon

[Filip Fila]

filipf requested changes to this revision.
filipf added a comment.
This revision now requires changes to proceed.


  Tested on 5.16 so disregard the other changes:
  
  **Before (dark Plasma theme, light color scheme):**
  F7273034: image.png <https://phabricator.kde.org/F7273034>
  
  **After (dark Plasma theme, light color scheme):**
  F7273045: image.png <https://phabricator.kde.org/F7273045>
  
  **Before (light Plasma theme, light color scheme):**
  F7273037: image.png <https://phabricator.kde.org/F7273037>
  
  **After (light Plasma theme, light color scheme):**
  F7273048: image.png <https://phabricator.kde.org/F7273048>
  
  **Before (color-aware Plasma theme, dark color scheme):**
  F7273039: image.png <https://phabricator.kde.org/F7273039>
  
  **After (color-aware Plasma theme, dark color scheme):**
  F7273042: image.png <https://phabricator.kde.org/F7273042>
  
  ___________________________________
  
  +1 for the idea, but two problems are evident:
  
  - at least one new Kirigami icon is not monochrome -> `input-mouse`
  - at least one new Kirigami icon is not color scheme-aware -> `battery-full`
  
  Other icons should also be checked, wouldn't hurt to see what support in other icons themes is like as well.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23368

To: ngraham, #plasma, broulik, meven, filipf
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190823/e6108ea2/attachment.html>