<table><tr><td style="">filipf requested changes to this revision.<br />filipf added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23368">View Revision</a></tr></table><br /><div><div><p>Tested on 5.16 so disregard the other changes:</p>
<p><strong>Before (dark Plasma theme, light color scheme):</strong><br />
<a href="https://phabricator.kde.org/F7273034" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7273034: image.png</a></p>
<p><strong>After (dark Plasma theme, light color scheme):</strong><br />
<a href="https://phabricator.kde.org/F7273045" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7273045: image.png</a></p>
<p><strong>Before (light Plasma theme, light color scheme):</strong><br />
<a href="https://phabricator.kde.org/F7273037" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7273037: image.png</a></p>
<p><strong>After (light Plasma theme, light color scheme):</strong><br />
<a href="https://phabricator.kde.org/F7273048" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7273048: image.png</a></p>
<p><strong>Before (color-aware Plasma theme, dark color scheme):</strong><br />
<a href="https://phabricator.kde.org/F7273039" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7273039: image.png</a></p>
<p><strong>After (color-aware Plasma theme, dark color scheme):</strong><br />
<a href="https://phabricator.kde.org/F7273042" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7273042: image.png</a></p>
<hr class="remarkup-hr" />
<p>+1 for the idea, but two problems are evident:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">at least one new Kirigami icon is not monochrome -> <tt style="background: #ebebeb; font-size: 13px;">input-mouse</tt></li>
<li class="remarkup-list-item">at least one new Kirigami icon is not color scheme-aware -> <tt style="background: #ebebeb; font-size: 13px;">battery-full</tt></li>
</ul>
<p>Other icons should also be checked, wouldn't hurt to see what support in other icons themes is like as well.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23368">https://phabricator.kde.org/D23368</a></div></div><br /><div><strong>To: </strong>ngraham, Plasma, broulik, meven, filipf<br /><strong>Cc: </strong>filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>