D21860: Set a font for gtk applications in the fonts kcm

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> fonts.cpp:613
> +    org::kde::gtkConfigd gtkDaemonInterface {
> +        "org.kde.gtkConfigd",
> +        "/KdeGtkConfigd",

QStringLiteral() around strings

> fonts.cpp:618
> +    };
> +    QString fontAsGtkConfigString = m_generalFont.family() + " "
> +            + m_generalFont.styleName() + " "

I think the specific string should be determined by the gtkconfig daemon

> fonts.cpp:621
> +            + QString::number(m_generalFont.pointSize());
> +    gtkDaemonInterface.changeGtkFont(fontAsGtkConfigString);
> +}

We know it will be about GTK, so changeFont should be enough.

Also, setFont would be more consistent with other API naming

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21860

To: gikari, #plasma, apol
Cc: nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190818/e3c42e6a/attachment-0001.html>