D23158: [Kickoff] Improve appearance of draggable button grid in settings window

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Intention makes sense, as do most the changes. Just some minor comments.

INLINE COMMENTS

> ConfigGeneral.qml:124
> +        Layout.topMargin: units.gridUnit
> +        Layout.bottomMargin: -units.gridUnit
>      }

What's this about? It's typically a sign that something else is wrong.

Probably the lack of spacer in this dialog means the label below occupies quite large box that it's in the middle of.

Try aligning the label below to the top instead.

> KickoffConfigurationButton.qml:45
> +            Layout.alignment: Qt.AlignHCenter
> +            width: units.iconSizes.medium
> +            height: width

It's almost always wrong to specify a width inside a ColumnLayout.

use implicitWidth or Layout.preferredWidth

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23158

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190814/92b54fe9/attachment.html>