D23158: [Kickoff] Improve appearance of draggable button grid in settings window

Nathaniel Graham noreply at phabricator.kde.org
Wed Aug 14 18:33:39 BST 2019


ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The button grid was not centered, the content inside the buttons was not centered, the
  vertical spacing was too high on top and too low on bottom, and the explanatory text
  got cut off.
  
  This patch solves all those problems.
  
  BUG: 409957
  FIXED-IN: 5.17.0

TEST PLAN
  Before: F7247447: Before.png <https://phabricator.kde.org/F7247447>
  After: F7247446: After.png <https://phabricator.kde.org/F7247446>

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-kickoff-settings-button-grid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23158

AFFECTED FILES
  applets/kickoff/package/contents/ui/ConfigButtons.qml
  applets/kickoff/package/contents/ui/ConfigGeneral.qml
  applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190814/01d9388d/attachment.html>


More information about the Plasma-devel mailing list