D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

Camilo Higuita noreply at phabricator.kde.org
Wed Aug 14 15:22:05 BST 2019


camiloh updated this revision to Diff 63725.
camiloh added a comment.


  fallback to custom kirigamiAction property for PrivateActionToolButton
  
  - useage of the fallback property due to: if we use QQC2.ToolButton default action property then the style will draw the content, and since this component draws the dropDown icon it still needs to be able to draw its own content in place, so the kirigamiAction hides the action prop and then avoids duplicating of icons.
  
  Still, an ideal solution would be to be able to let the style draw the content, but there was not an easy way to anchors the dropDown icon in a nice manner by relaying on the style.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22974?vs=63242&id=63725

BRANCH
  k-action-to-qqc2-action (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22974

AFFECTED FILES
  src/controls/Action.qml
  src/controls/ActionToolBar.qml
  src/controls/private/ActionButton.qml
  src/controls/private/ActionsMenu.qml
  src/controls/private/GlobalDrawerActionItem.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/private/globaltoolbar/ToolBarPageHeader.qml

To: camiloh, #kirigami, mart
Cc: astippich, apol, plasma-devel, fbampaloukas, domson, dkardarakos, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190814/cbbb7743/attachment-0001.html>


More information about the Plasma-devel mailing list