D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

Marco Martin noreply at phabricator.kde.org
Wed Aug 7 14:50:41 BST 2019


mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  good direction, unfortunately we can't remove the custom toolbutton contentitem yet, so for now let's keep the custom icon group

INLINE COMMENTS

> camiloh wrote in Action.qml:76
> from Kirigami actionIconGroup:
> string name
> string source
> int width
> int height
> color color
> 
> from QQC2 icon property:
> icon.name
> icon.source
> icon.width
> icon.height
> icon.color

ok, please remove all code that you commented out

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22974

To: camiloh, #kirigami, mart
Cc: astippich, apol, plasma-devel, fbampaloukas, domson, dkardarakos, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190807/5cb8abfb/attachment.html>


More information about the Plasma-devel mailing list