D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

Roman Gilg noreply at phabricator.kde.org
Wed Aug 7 19:54:27 BST 2019


romangg added a comment.


  In D22468#508314 <https://phabricator.kde.org/D22468#508314>, @ngraham wrote:
  
  > In D22468#508290 <https://phabricator.kde.org/D22468#508290>, @romangg wrote:
  >
  > > I currently concentrate on libkscreen backend work and output duplication and have based other patches on this rewrite here. So I only want to touch this diff again in case of critical issues but not add more detail work on top of what's already there. Instead after merge of the rewrite please create a task with your list of ideas so we can go with multiple small patches afterwards. Also some of these points should be discussed some more and a task is better suited for that.
  >
  >
  > I can do that, but in principle I think when a patch involves a UI rewrite, it's fair game to offer UI suggestions. If you don't want to change the new UI you've written in this patch, it might be better to break this patch up into a backend component that you can use as a base for other patches, and a front-end leaf node patch where we can do the UI review independently of the other dependent backend work.
  
  
  Problem is that you can't really break this patch up since the front- and back-end changes are dependent on each other. But it's definitely fine to further refine the Ui afterwards. I see the Ui more as a first revision than the end goal. And because of that I want to break up continuous work into smaller chunks as soon as possible after a large rewrite involving both front- and back-end. This gives other front-end contributors a chance to put in their own ideas and me concentrate on the back-end again.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg, ngraham
Cc: #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf, plasma-devel, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190807/f0b953e2/attachment-0001.html>


More information about the Plasma-devel mailing list