D22988: Fix incorrect Kickoff tab bar layout for vertical panels

Konstantin Lisin noreply at phabricator.kde.org
Wed Aug 7 11:55:27 BST 2019


lisin created this revision.
lisin added reviewers: Plasma, hein, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
lisin requested review of this revision.

REVISION SUMMARY
  This fixes the incorrect initial positioning of the tab bar (first tab is placed out of bounds) when Kickoff is in a vertical panel that persists until the user selects another tab manually.
  BUG: 395390
  
  And the broken layout of the tab bar (tab bar takes the whole view) when a panel is changed from horizontal to vertical that persists until plasmashell is restarted.
  BUG: 393888

TEST PLAN
  BUG: 395390
  Place Kickoff in a vertical panel. Restart plasmashell and open Kickoff.
  Before fix: first tab is positioned out of bounds (y<0).
  After fix: first tab is positioned correctly (y=0).
  
  BUG: 393888
  Change panel orientation from horizontal to vertical. Open Kickoff.
  Before fix: tab bar fills the whole view making the Kickoff unusable even if you make the panel horizontal again.
  After fix: tab bar has the correct size.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22988

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: lisin, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190807/ee43a75b/attachment.html>


More information about the Plasma-devel mailing list