D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> icon.cpp:406
> +        m_networkReply = qnam->get(request);
> +        connect(m_networkReply.data(), &QNetworkReply::finished, this, [this](){handleFinished(m_networkReply); });
>      }

Just noticed, doesn't the `m_networkReply` leak? It's not deleted in `handleFinished`

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22952

To: apol, #frameworks, #kirigami
Cc: broulik, plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190806/0a1357d0/attachment-0001.html>