<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22952">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22952#inline-129531">View Inline</a><span style="color: #4b4d51; font-weight: bold;">icon.cpp:406</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">m_networkReply</span> <span style="color: #aa2211">=</span> <span class="n">qnam</span><span style="color: #aa2211">-></span><span class="n">get</span><span class="p">(</span><span class="n">request</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="bright">    </span><span class="n">connect</span><span class="p">(</span><span class="n">m_networkReply</span><span class="p">.</span><span class="n">data</span><span class="p">(),</span> <span style="color: #aa2211">&</span><span class="n">QNetworkReply</span><span style="color: #aa2211">::<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">readyRea</span>d</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">](){</span><span class="n">handle<span class="bright">ReadyRea</span>d</span><span class="p">(</span><span class="n">m_networkReply</span><span class="p">);</span> <span class="p">});</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="n">connect</span><span class="p">(</span><span class="n">m_networkReply</span><span class="p">.</span><span class="n">data</span><span class="p">(),</span> <span style="color: #aa2211">&</span><span class="n">QNetworkReply</span><span style="color: #aa2211">::</span><span class="n">finished</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">qnam</span><span class="p">](){</span><span class="n">handleFinished</span><span class="p">(</span><span class="n">qnam</span><span class="p">,</span> <span class="n">m_networkReply</span><span class="p">);</span> <span class="p">});</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #aa4000">return</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">connect</span><span class="p">(</span><span class="n">m_networkReply</span><span class="p">.</span><span class="n">data</span><span class="p">(),</span> <span style="color: #aa2211">&</span><span class="n">QNetworkReply</span><span style="color: #aa2211">::<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">finishe</span>d</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">](){</span><span class="n">handle<span class="bright">Finishe</span>d</span><span class="p">(</span><span class="n">m_networkReply</span><span class="p">);</span> <span class="p">});</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Just noticed, doesn't the <tt style="background: #ebebeb; font-size: 13px;">m_networkReply</tt> leak? It's not deleted in <tt style="background: #ebebeb; font-size: 13px;">handleFinished</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22952">https://phabricator.kde.org/D22952</a></div></div><br /><div><strong>To: </strong>apol, Frameworks, Kirigami<br /><strong>Cc: </strong>broulik, plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein<br /></div>