D20896: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Thanks for the patch, good to have consistency, Cannot test the next days, but could not spot anything raising my eyebrows on a quick look, so if you feel confident, please go ahead and push for field testing ;)
  
  About the blank Visibility combobox, that works for me in Plasma 5.15. Must be some regression elsewhere, please file a bug if you can, I will try to look at it next week.

INLINE COMMENTS

> ConfigWeatherStation.qml:85
> +            id: selectButton
> +            icon.name: "find-location-symbolic"
> +            text: i18nc("@action:button", "Choose...")

While I see this: what are all those "-symbolic" variants and when would one use it? Is that documented anywhere? I expeted something on hig.kde.org, but found nothing.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D20896

To: ngraham, #vdg, #plasma, kossebau
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190429/080ff8e1/attachment.html>