<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20896">View Revision</a></tr></table><br /><div><div><p>Thanks for the patch, good to have consistency, Cannot test the next days, but could not spot anything raising my eyebrows on a quick look, so if you feel confident, please go ahead and push for field testing ;)</p>
<p>About the blank Visibility combobox, that works for me in Plasma 5.15. Must be some regression elsewhere, please file a bug if you can, I will try to look at it next week.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20896#inline-117330">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ConfigWeatherStation.qml:85</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">id: selectButton</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"> </span><span style="color: #aa4000">icon<span class="bright">N</span>ame:</span> <span style="color: #766510">"<span class="bright">edit-</span>find"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"> </span><span style="color: #aa4000">text:</span> <span style="color: #004012">i18nc</span><span class="p">(</span><span style="color: #766510">"@action:button"</span><span class="p">,</span> <span style="color: #766510">"<span class="bright">Select</span>"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">icon<span class="bright">.n</span>ame:</span> <span style="color: #766510">"find<span class="bright">-location-symbolic</span>"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">text:</span> <span style="color: #004012">i18nc</span><span class="p">(</span><span style="color: #766510">"@action:button"</span><span class="p">,</span> <span style="color: #766510">"<span class="bright">Choose...</span>"</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">While I see this: what are all those "-symbolic" variants and when would one use it? Is that documented anywhere? I expeted something on hig.kde.org, but found nothing.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20896">https://phabricator.kde.org/D20896</a></div></div><br /><div><strong>To: </strong>ngraham, VDG, Plasma, kossebau<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>