D20786: ProcessList: add support for cgroups

Anthony Fieroni noreply at phabricator.kde.org
Sat Apr 27 06:15:48 BST 2019


anthonyfieroni added inline comments.

INLINE COMMENTS

> ProcessList.c:420-421
> +    if ( buf[0] == '0' && buf[1] == ':' && buf[2] == ':' ) {
> +      while (buf[strlen(buf) - 1] == '\n')
> +        buf[strlen(buf) - 1] = '\0'; /* trim trailing newlines */
> +      ps->cGroup = strdup( &buf[3] );

for (int i = strlen(buf) - 1; buf[i] == '\n'; i++)
      buf[i] = '\0';

> ProcessList.c:422
> +        buf[strlen(buf) - 1] = '\0'; /* trim trailing newlines */
> +      ps->cGroup = strdup( &buf[3] );
> +    }

strdup allocates memory i don't see where you free it.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D20786

To: topimiettinen, #plasma, hein
Cc: anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190427/25803ede/attachment-0001.html>


More information about the Plasma-devel mailing list