<table><tr><td style="">anthonyfieroni added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20786">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20786#inline-117098">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ProcessList.c:420-421</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span> <span class="n">buf</span><span class="p">[</span><span style="color: #601200">0</span><span class="p">]</span> <span style="color: #aa2211">==</span> <span style="color: #766510">'0'</span> <span style="color: #aa2211">&&</span> <span class="n">buf</span><span class="p">[</span><span style="color: #601200">1</span><span class="p">]</span> <span style="color: #aa2211">==</span> <span style="color: #766510">':'</span> <span style="color: #aa2211">&&</span> <span class="n">buf</span><span class="p">[</span><span style="color: #601200">2</span><span class="p">]</span> <span style="color: #aa2211">==</span> <span style="color: #766510">':'</span> <span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">      <span style="color: #aa4000">while</span> <span class="p">(</span><span class="n">buf</span><span class="p">[</span><span class="n">strlen</span><span class="p">(</span><span class="n">buf</span><span class="p">)</span> <span style="color: #aa2211">-</span> <span style="color: #601200">1</span><span class="p">]</span> <span style="color: #aa2211">==</span> <span style="color: #766510">'\n'</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">buf</span><span class="p">[</span><span class="n">strlen</span><span class="p">(</span><span class="n">buf</span><span class="p">)</span> <span style="color: #aa2211">-</span> <span style="color: #601200">1</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span style="color: #766510">'\0'</span><span class="p">;</span> <span style="color: #74777d">/* trim trailing newlines */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">      <span class="n">ps</span><span style="color: #aa2211">-></span><span class="n">cGroup</span> <span style="color: #aa2211">=</span> <span class="n">strdup</span><span class="p">(</span> <span style="color: #aa2211">&</span><span class="n">buf</span><span class="p">[</span><span style="color: #601200">3</span><span class="p">]</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">for (int i = strlen(buf) - 1; buf[i] == '\n'; i++)
    buf[i] = '\0';</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20786#inline-117099">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ProcessList.c:422</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">buf</span><span class="p">[</span><span class="n">strlen</span><span class="p">(</span><span class="n">buf</span><span class="p">)</span> <span style="color: #aa2211">-</span> <span style="color: #601200">1</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span style="color: #766510">'\0'</span><span class="p">;</span> <span style="color: #74777d">/* trim trailing newlines */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">      <span class="n">ps</span><span style="color: #aa2211">-></span><span class="n">cGroup</span> <span style="color: #aa2211">=</span> <span class="n">strdup</span><span class="p">(</span> <span style="color: #aa2211">&</span><span class="n">buf</span><span class="p">[</span><span style="color: #601200">3</span><span class="p">]</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">strdup allocates memory i don't see where you free it.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R106 KSysguard</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20786">https://phabricator.kde.org/D20786</a></div></div><br /><div><strong>To: </strong>topimiettinen, Plasma, hein<br /><strong>Cc: </strong>anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>