D20585: [FormLayout] RFC: Use even top and bottom spacing for separator

Filip Fila noreply at phabricator.kde.org
Fri Apr 26 13:08:12 BST 2019


filipf added a comment.


  @mart are you sure this is the right solution? From my tests the patch also adds extra spacing whenever there is an instance of `isSection`, but we'd only want it to do so when there is a separator present.
  
  Before:
  F6794817: Screenshot_20190426_133016.png <https://phabricator.kde.org/F6794817>
  
  After:
  F6794819: Screenshot_20190426_133914.png <https://phabricator.kde.org/F6794819>
  
  We can see in this example when there is no separator that extra (unwanted) spacing has been added.

REPOSITORY
  R169 Kirigami

BRANCH
  even-separator-spacing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20585

To: filipf, mart, #kirigami, ngraham
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190426/87d4d8b0/attachment.html>


More information about the Plasma-devel mailing list