<table><tr><td style="">filipf added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20585">View Revision</a></tr></table><br /><div><div><p><a href="https://phabricator.kde.org/p/mart/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@mart</a> are you sure this is the right solution? From my tests the patch also adds extra spacing whenever there is an instance of <tt style="background: #ebebeb; font-size: 13px;">isSection</tt>, but we'd only want it to do so when there is a separator present.</p>
<p>Before:<br />
<a href="https://phabricator.kde.org/F6794817" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6794817: Screenshot_20190426_133016.png</a></p>
<p>After:<br />
<a href="https://phabricator.kde.org/F6794819" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6794819: Screenshot_20190426_133914.png</a></p>
<p>We can see in this example when there is no separator that extra (unwanted) spacing has been added.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><strong>BRANCH</strong><div><div>even-separator-spacing (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20585">https://phabricator.kde.org/D20585</a></div></div><br /><div><strong>To: </strong>filipf, mart, Kirigami, ngraham<br /><strong>Cc: </strong>plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein<br /></div>