D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

[Méven Car]

meven added a comment.


  
  
  In D20598#456309 <https://phabricator.kde.org/D20598#456309>, @filipf wrote:
  
  > Works for me, nice work with aligning the layouts.
  >
  > I'm a bit conflicted, but I think visually the issue is how these buttons look like with the port, as well as their icons (but that was a problem before as well):
  >
  > F6793389: image.png <https://phabricator.kde.org/F6793389>
  >
  > Before they had a useless frame, but the buttons had a border on all 4 sides:
  >
  > F6793398: image.png <https://phabricator.kde.org/F6793398>
  >
  > Losing the bottom maybe makes sense, but feels disconnected here IMO.
  
  
  I am using the dark theme and those buttons are pretty much
  
  In D20598#456309 <https://phabricator.kde.org/D20598#456309>, @filipf wrote:
  
  > Works for me, nice work with aligning the layouts.
  >
  > I'm a bit conflicted, but I think visually the issue is how these buttons look like with the port, as well as their icons (but that was a problem before as well):
  >
  > F6793389: image.png <https://phabricator.kde.org/F6793389>
  >
  > Before they had a useless frame, but the buttons had a border on all 4 sides:
  >
  > F6793398: image.png <https://phabricator.kde.org/F6793398>
  >
  > Losing the bottom maybe makes sense, but feels disconnected here IMO.
  
  
  I don't see those buttons, I guess you need a remote mouse or something similar to have them.

INLINE COMMENTS

> main.qml:21
> +import QtQuick 2.5
> +import QtQuick.Controls 2.12
>  import QtQuick.Layouts 1.1

I might be too aggressive here, what would be the best version to set here ?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D20598

To: meven, ngraham, broulik, filipf
Cc: filipf, davidre, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190425/3e82bf8a/attachment.html>