D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

Filip Fila noreply at phabricator.kde.org
Thu Apr 25 21:03:40 BST 2019


filipf added a comment.


  Works for me, nice work with aligning the layouts.
  
  I'm a bit conflicted, but I think visually the issue is how these buttons look like with the port, as well as their icons (but that was a problem before as well):
  
  F6793389: image.png <https://phabricator.kde.org/F6793389>
  
  Before they had a useless frame, but the buttons had a border on all 4 sides:
  
  F6793398: image.png <https://phabricator.kde.org/F6793398>
  
  Losing the bottom maybe makes sense, but feels disconnected here IMO.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D20598

To: meven, ngraham, broulik, filipf
Cc: filipf, davidre, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190425/fc44ef15/attachment.html>


More information about the Plasma-devel mailing list