D20819: Make really sure we show an error message in case saving failed

Fabian Vogt noreply at phabricator.kde.org
Thu Apr 25 17:17:18 BST 2019


fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> options.js:174
> +                            // When the extension is reloaded, any call to extension APIs throws, make sure we show at least some form of error
> +                            saveMessage.innerText = "Saving settings failed (" + e + ")";
> +                        }

This should show `error` as well

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D20819

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190425/c845dbb5/attachment.html>


More information about the Plasma-devel mailing list