D20819: Make really sure we show an error message in case saving failed

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When the extension is reloaded, its context is invalidated and any call to an extension API would just throw.
  Catch the most important bits of error reporting on save, so you're not left wondering why your settings don't change.

TEST PLAN
  Was working on some settings bits, had to reload the extension often to test things and was always wondering why it didn't do anything when I forgot to also reload the settings page
  
  Now at least I get an error of sorts:
  
  > Saving settings failed (Error: Extension context invalidated.)

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D20819

AFFECTED FILES
  extension/options.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190425/7490f327/attachment-0001.html>