D20724: Keep player around when emptied but the website tells us it's actually just paused

Fabian Vogt noreply at phabricator.kde.org
Mon Apr 22 10:02:38 BST 2019


fvogt added inline comments.

INLINE COMMENTS

> broulik wrote in content-script.js:358
> No. This case here is so when you empty the player, e.g. use ajax page nav to navigate away, we stop controlling the player. It is always paused when emptied, so this would just noop.
> With media session api we give the website some control of providing a playback status we communicate to the user regardless of their implementation detail.
> In theory they could even show media controls without ever using a HTML5 audio/video object (which we don't support as of now) purely using media sessions

Ok, so this is even more of a hack than I thought. Can you add a `&& player == activePlayer` check there?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D20724

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190422/7109a16d/attachment.html>


More information about the Plasma-devel mailing list