D20237: Port to new KWorkspace API

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Apr 4 20:05:57 BST 2019


apol added inline comments.

INLINE COMMENTS

> hein wrote in ItemGridDelegate.qml:33
> QVariant() evaluates to false, and not all models implement this role to return `true` by default. Hence the check for an explicit false.
> 
> The alternative would be to patch all the models.

so model.enabled you want it to resolve to true? This will be hard to read to anyone who isn't you.

How about `model.hasOwnProperty("enabled") && model.enabled`? Or `typeof model.enabled === "undefined" || model.enabled`

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20237

To: hein, #plasma, davidedmundson
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190404/e84a3078/attachment.html>


More information about the Plasma-devel mailing list