D20237: Port to new KWorkspace API

Eike Hein noreply at phabricator.kde.org
Thu Apr 4 13:39:08 BST 2019


hein added inline comments.

INLINE COMMENTS

> apol wrote in ItemGridDelegate.qml:33
> `enabled: model.enabled` no?

QVariant() evaluates to false, and not all models implement this role to return `true` by default. Hence the check for an explicit false.

The alternative would be to patch all the models.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20237

To: hein, #plasma, davidedmundson
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190404/585d38bd/attachment.html>


More information about the Plasma-devel mailing list