D19822: [Task Manager] Toggle mute when the audio indicator is clicked
Filip Fila
noreply at phabricator.kde.org
Tue Apr 2 14:35:29 BST 2019
filipf resigned from this revision.
filipf added a comment.
Highlight color is nice, but in my tests I really like having red for the muting because it gets the point across that a disabling action will be triggered. Therefore the code I have now is:
`color: mouseArea.containsMouse? (task.muted? theme.highlightColor : theme.negativeTextColor) : theme.textColor`
Which then ends up looking like:
F6745684: AudioHover <https://phabricator.kde.org/F6745684>
However there is an inconsistency issue the Kirigami icon brings about (@mart perhaps you might know why?). It picks up a different muted icon (code points it to the same icon) than IconItem which results in an inconsistency with the media applet muted icon:
F6745676: Screenshot_20190402_151328.png <https://phabricator.kde.org/F6745676>
BTW I'm getting no interference of the color property with Oxygen icons, there is no coloring applied to them.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D19822
To: faridb, #plasma, #vdg, ngraham, hein
Cc: mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190402/d8352c3f/attachment.html>
More information about the Plasma-devel
mailing list