<table><tr><td style="">filipf resigned from this revision.<br />filipf added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19822">View Revision</a></tr></table><br /><div><div><p>Highlight color is nice, but in my tests I really like having red for the muting because it gets the point across that a disabling action will be triggered. Therefore the code I have now is:</p>
<p><tt style="background: #ebebeb; font-size: 13px;">color: mouseArea.containsMouse? (task.muted? theme.highlightColor : theme.negativeTextColor) : theme.textColor</tt></p>
<p>Which then ends up looking like:</p>
<p><a href="https://phabricator.kde.org/F6745684" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6745684: AudioHover</a></p>
<p>However there is an inconsistency issue the Kirigami icon brings about (<a href="https://phabricator.kde.org/p/mart/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@mart</a> perhaps you might know why?). It picks up a different muted icon (code points it to the same icon) than IconItem which results in an inconsistency with the media applet muted icon:</p>
<p><a href="https://phabricator.kde.org/F6745676" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6745676: Screenshot_20190402_151328.png</a></p>
<p>BTW I'm getting no interference of the color property with Oxygen icons, there is no coloring applied to them.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19822">https://phabricator.kde.org/D19822</a></div></div><br /><div><strong>To: </strong>faridb, Plasma, VDG, ngraham, hein<br /><strong>Cc: </strong>mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>