D14542: WIP: Basic KCM using new virtual desktops DBus interface
Eike Hein
noreply at phabricator.kde.org
Sun Sep 30 12:35:50 BST 2018
hein updated this revision to Diff 42592.
hein edited the summary of this revision.
hein added a comment.
Fully implement delayed-apply.
Conflicts between user edits and server-side changes are resolved
as follows:
- If the user hasn't made any edits vs. the server state, the KCM keeps in sync transparently.
- If the user has made edits and the server signals a change, an InlineMessage is used to inform the user that saving will over- write the externally-made changes.
- Saving user edits is done via a synchronization loop until the states are in sync again.
Call errors while saving user edits are now handled. If a call
error occurs during synchronization, it's aborted in a way that
allows the user to try again with another click on Apply/Ok.
I changed the dummy intro string above the list into something
more appropriate.
I still need Marco to look at the two FIXMEs in the code that
point out KWin quirks (also mentioned in the description).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14542?vs=39009&id=42592
BRANCH
arcpatch-D14542
REVISION DETAIL
https://phabricator.kde.org/D14542
AFFECTED FILES
kcmkwin/CMakeLists.txt
kcmkwin/kwindesktopng/CMakeLists.txt
kcmkwin/kwindesktopng/Messages.sh
kcmkwin/kwindesktopng/desktopsmodel.cpp
kcmkwin/kwindesktopng/desktopsmodel.h
kcmkwin/kwindesktopng/kcm_kwin_virtualdesktops.desktop
kcmkwin/kwindesktopng/org.kde.kwin.virtualdesktopmanager.xml
kcmkwin/kwindesktopng/package/contents/ui/main.qml
kcmkwin/kwindesktopng/package/metadata.desktop
kcmkwin/kwindesktopng/virtualdesktops.cpp
kcmkwin/kwindesktopng/virtualdesktops.h
To: hein, mart, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180930/db04c356/attachment.html>
More information about the Plasma-devel
mailing list