D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

David Edmundson noreply at phabricator.kde.org
Sun Sep 9 15:53:55 BST 2018


davidedmundson added a comment.


  RunnerContext::addMatches has it's own duplicate check based on match.id
  
  We're not explicitly setting that currently.
  I think we can just do  match.setId("bookmarks"+url+title); and have everything handled auto-magically.
  
  If that does work it will be less code with the same results, faster and even handle dupes in both firefox and chrome bookmarks. Win win.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15357

To: bruns, #plasma
Cc: davidedmundson, zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180909/8ace7164/attachment.html>


More information about the Plasma-devel mailing list