<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15357">View Revision</a></tr></table><br /><div><div><p>RunnerContext::addMatches has it's own duplicate check based on match.id</p>
<p>We're not explicitly setting that currently.<br />
I think we can just do match.setId("bookmarks"+url+title); and have everything handled auto-magically.</p>
<p>If that does work it will be less code with the same results, faster and even handle dupes in both firefox and chrome bookmarks. Win win.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15357">https://phabricator.kde.org/D15357</a></div></div><br /><div><strong>To: </strong>bruns, Plasma<br /><strong>Cc: </strong>davidedmundson, zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>