D15306: BookmarksRunner: Avoid multiple connections of identical signal

Stefan BrĂ¼ns noreply at phabricator.kde.org
Thu Sep 6 14:39:35 BST 2018


bruns added inline comments.

INLINE COMMENTS

> broulik wrote in bookmarksrunner.cpp:66
> Ah, yeah, right, and then you could connect direcftly:
> 
>   connect(this, &Plasma::AbstractRunner:teardown, m_browser, &Browser::teardown);

yes, after readding the `dynamic_cast<QObject*>`, m_browser is a non-QObject interface class.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15306

To: bruns, #plasma
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180906/840dbb6c/attachment-0001.html>


More information about the Plasma-devel mailing list