D15306: BookmarksRunner: Avoid multiple connections of identical signal

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Sep 6 14:37:29 BST 2018


broulik added inline comments.

INLINE COMMENTS

> bruns wrote in bookmarksrunner.cpp:66
> Hm, just found that auto-disconnect (see @davidedmundson s comment) only works if you provide a context. The context has to be `m_browser`  here.

Ah, yeah, right, and then you could connect direcftly:

  connect(this, &Plasma::AbstractRunner:teardown, m_browser, &Browser::teardown);

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15306

To: bruns, #plasma
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180906/c6b62a88/attachment.html>


More information about the Plasma-devel mailing list