D15306: BookmarksRunner: Avoid multiple connections of identical signal

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Sep 6 14:19:38 BST 2018


broulik added inline comments.

INLINE COMMENTS

> bruns wrote in bookmarksrunner.cpp:66
> you mean `this->mbrowser->teardown()`?

No, four-argument connect:

  connect(this, &..., this, ....

Though you just connect from `this` anyway, so I guess this isn't needed

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15306

To: bruns, #plasma
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180906/1ab8b14f/attachment.html>


More information about the Plasma-devel mailing list