D15306: BookmarksRunner: Avoid multiple connections of identical signal

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> davidedmundson wrote in bookmarksrunner.cpp:65
> do we not also need a disconnect on m_browser?

Browser is just an interface class, but the subclasses also derive from QObject and should auto-disconnect, AFAIK.

> broulik wrote in bookmarksrunner.cpp:66
> Please provide `this` as context.

you mean `this->mbrowser->teardown()`?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15306

To: bruns, #plasma
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180906/151dc580/attachment.html>