D15306: BookmarksRunner: Avoid multiple connections of identical signal

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Sep 6 07:42:02 BST 2018


broulik added a comment.


  Can't you connect to the slot directly and use `Qt::UniqueConnection`?

INLINE COMMENTS

> bookmarksrunner.cpp:66
> +        m_browser = browser;
> +        connect(this, &Plasma::AbstractRunner::teardown, [this]() { m_browser->teardown(); });
> +    }

Please provide `this` as context.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15306

To: bruns, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180906/4b06a6c4/attachment.html>


More information about the Plasma-devel mailing list