D15306: BookmarksRunner: Avoid multiple connections of identical signal

Stefan BrĂ¼ns noreply at phabricator.kde.org
Thu Sep 6 03:03:44 BST 2018


bruns created this revision.
bruns added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The factory returns the same object when the browser name is not changed.
  Connecting the signal again leads to multiple calls to the slot each
  time the signal is emitted.
  
  See also T9626 <https://phabricator.kde.org/T9626>

TEST PLAN
  1. Add some debug output to the teardown() slot
  2. Open the krunner multiple times and enter some query
  3. teardown() is called exactly once

REPOSITORY
  R120 Plasma Workspace

BRANCH
  T9626

REVISION DETAIL
  https://phabricator.kde.org/D15306

AFFECTED FILES
  runners/bookmarks/bookmarksrunner.cpp

To: bruns, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180906/4b1bfcba/attachment-0001.html>


More information about the Plasma-devel mailing list