D15243: Remove some double look-ups
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Tue Sep 4 00:49:15 BST 2018
apol marked an inline comment as done.
apol added inline comments.
INLINE COMMENTS
> broulik wrote in delegaterecycler.cpp:73
> `m_refs.erase(itRef)`?
Thanks!
> broulik wrote in delegaterecycler.cpp:83
> Unrelated question: Where does this get removed from `items`?
They are unused items (delegate instances), they get deleted when it's destroyed.
The code looks good to me.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D15243
To: apol, #kirigami, mart
Cc: broulik, plasma-devel, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180903/7c258ba7/attachment.html>
More information about the Plasma-devel
mailing list