D15243: Remove some double look-ups

[Kai Uwe Broulik]

broulik added a comment.


  +1

INLINE COMMENTS

> delegaterecycler.cpp:73
> +    if (*itRef <= 0) {
>          m_refs.remove(component);
> +

`m_refs.erase(itRef)`?

> delegaterecycler.cpp:83
> +    if (items.length() >= s_cacheSize) {
>          item->deleteLater();
>          return;

Unrelated question: Where does this get removed from `items`?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15243

To: apol, #kirigami, mart
Cc: broulik, plasma-devel, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180903/ae99fdcb/attachment-0001.html>