D16277: [ksmserver] Split xsession logout and shutdown into separate classes

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> shutdown.cpp:31
>  {
> -    if ( state != Idle )
> -        return;
> -    sessionGroup = QStringLiteral( "Session: " ) + session;
> -    saveCurrentSession();
> +    m_shutdownType = KWorkSpace::ShutdownTypeNone;
> +    startLogout();

If you have to set it before calling startLogout(), maybe it would work better as an argument.

> shutdown.cpp:68
> +        QDir dir(shutDownFolder);
> +        if (!dir.exists()) {
>              continue;

Is it really possible for ::locateAll to return directories that don't exist?

> shutdown.h:1
> +#pragma once
> +

It's missing the license.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16277

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181030/504b2c70/attachment-0001.html>