D16417: Improve replacement text when action description is not provided

Stefan BrĂ¼ns noreply at phabricator.kde.org
Wed Oct 24 21:51:33 BST 2018


bruns added inline comments.

INLINE COMMENTS

> ngraham wrote in AuthDialog.cpp:356
> So I gather `.isEmpty()` works now?

Yes.

> ngraham wrote in AuthDialog.cpp:359
> I would prefer "not available" over "not provided", but I won't choose this as my hill to die on. :)
> 
> Do we actually need to repeat the word 'Description' here?

There is no repetition here - the Polkit "<description>" is labeled "Action:" in the dialog.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D16417

To: bruns, #plasma, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181024/8e776045/attachment-0001.html>


More information about the Plasma-devel mailing list