D16417: Improve replacement text when action description is not provided

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> AuthDialog.cpp:356
> -    // replace blank description
> -    // neither isEmpty() or isNull() worked (?)
> -    if (actionDescription.description() == "") {

So I gather `.isEmpty()` works now?

> AuthDialog.cpp:359
>          action_label->setFont(descrFont);
> -        action_label->setText(i18n("Not Applicable"));
> +        action_label->setText(i18n("'Description' not provided"));
>      } else {

I would prefer "not available" over "not provided", but I won't choose this as my hill to die on. :)

Do we actually need to repeat the word 'Description' here?

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D16417

To: bruns, #plasma, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181024/bf0ec424/attachment.html>