D16368: Swap Trash/Delete when Shift is used while the menu is open

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Oct 22 12:32:25 BST 2018


broulik added inline comments.

INLINE COMMENTS

> foldermodel.cpp:1854
>      menu->popup(m_menuPosition);
> -    connect(menu, &QMenu::aboutToHide, [menu]() { menu->deleteLater(); });
> +    connect(menu, &QMenu::aboutToHide, [this, menu]() {
> +        menu->deleteLater();

Use four argument connect since now you access `this` but given you delete the menu anyway,  this change probably isn't neccessary to begin with

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16368

To: hein, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181022/e572f9a7/attachment.html>


More information about the Plasma-devel mailing list