D16368: Swap Trash/Delete when Shift is used while the menu is open

David Edmundson noreply at phabricator.kde.org
Mon Oct 22 12:05:14 BST 2018


davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> foldermodel.cpp:653
> +    // Trash and Delete actions while the Shift modifier is pressed.
> +    // There's no point to doing so when the menu isn't open.
> +    if (m_menuPosition.isNull()) {

you delete the menu when the menu isn't open, you won't get any events

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16368

To: hein, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181022/35d59a51/attachment.html>


More information about the Plasma-devel mailing list