D16275: don't set a user if there is no user

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Oct 17 16:20:18 BST 2018


broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  I wonder why `QUrl` doesn't clean that up on its own

INLINE COMMENTS

> knetattach.cpp:204
>          url.setHost(_host->text().trimmed());
> -        url.setUserName(_user->text().trimmed());
> +        auto trimmedUser = _user->text().trimmed();
> +        if (!trimmedUser.isEmpty()) {

lazy, `const QString`

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16275

To: sitter, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181017/82579001/attachment-0001.html>


More information about the Plasma-devel mailing list