D15599: Port the "Switch Desktop" containment action to libtaskmanager

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> zzag wrote in desktop.cpp:73
> I didn't test it, but I think this one would be better:
> 
>   qDeleteAll(m_actions.begin() + numDesktops, m_actions.end());
>   m_actions.resize(numDesktops);

There's a bigger question.

What if you have 5 desktops, and you delete desktop 2?

We don't want the action for desktop 5 to be the one that's removed.

This either needs better change tracking or to just rebuild the list every time.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15599

To: hein, mart, davidedmundson
Cc: zzag, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181016/9be1da84/attachment-0001.html>