<table><tr><td style="">davidedmundson requested changes to this revision.<br />davidedmundson added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15599">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15599#inline-88365">View Inline</a><span style="color: #4b4d51; font-weight: bold;">zzag</span> wrote in <span style="color: #4b4d51; font-weight: bold;">desktop.cpp:73</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I didn't test it, but I think this one would be better:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span class="n">qDeleteAll</span><span class="p">(</span><span class="n">m_actions</span><span class="p">.</span><span class="n">begin</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">numDesktops</span><span class="p">,</span> <span class="n">m_actions</span><span class="p">.</span><span class="n">end</span><span class="p">());</span>
<span class="n">m_actions</span><span class="p">.</span><span class="n">resize</span><span class="p">(</span><span class="n">numDesktops</span><span class="p">);</span></pre></div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">There's a bigger question.</p>

<p style="padding: 0; margin: 8px;">What if you have 5 desktops, and you delete desktop 2?</p>

<p style="padding: 0; margin: 8px;">We don't want the action for desktop 5 to be the one that's removed.</p>

<p style="padding: 0; margin: 8px;">This either needs better change tracking or to just rebuild the list every time.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15599">https://phabricator.kde.org/D15599</a></div></div><br /><div><strong>To: </strong>hein, mart, davidedmundson<br /><strong>Cc: </strong>zzag, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>