D15702: User can define margins for the desktop

[David Edmundson]

davidedmundson added a comment.


  I fully understand we want something. I'm not convinced by this as-is.
  
  Code wise we already have something to make sure Containments don't overlap with hidden panels  (Corona::availableScreenRect) which we override in shellcorona, I don't think we need a second one at a different layer.
  
  UI wise, it seems non-optimial; latte dock users have to take a manual step and we get an additionally more complex UI.
  Does Latte know the size a user would want? Is there a use-case outside latte?

INLINE COMMENTS

> FolderView.qml:1127
> +                //! x,y values in acceptable values
> +                var boundedX = isContainment ? Math.min(Math.max(cellWidth / 2, x - main.anchors.leftMargin), scrollArea.width - cellWidth / 2) : x;
> +                var boundedY = isContainment ? Math.min(Math.max(cellHeight / 2, y - main.anchors.topMargin), scrollArea.height - cellHeight / 2) : y;

I don't understand this change?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15702

To: mvourlakos, #plasma, davidedmundson, mart
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181015/f0f76789/attachment.html>