D16095: [Background Model] Use own QCache for thumbnails
Kai Uwe Broulik
noreply at phabricator.kde.org
Wed Oct 10 10:31:56 BST 2018
broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Previously it would use an on-disk `KImageCache` which would never be invalidated. Moreover, it just uses `KIO::PreviewJob` which does its own more clever (compares mtime and other properties) on-disk caching already.
It's using its own `QCache` rather than `QPixmapCache` to not jeopardize other caching for the potentially large wallpaper thumbnails that are only relevant while the dialog iso pen.
BUG: 395447
FIXED-IN: 5.15.0
TEST PLAN
- Scrolled through the list, had thumbnails be generated and cached
- If there were too many some of them were discarded and this worked without crashing
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D16095
AFFECTED FILES
wallpapers/image/CMakeLists.txt
wallpapers/image/backgroundlistmodel.cpp
wallpapers/image/backgroundlistmodel.h
To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181010/fd2d6a0b/attachment-0001.html>
More information about the Plasma-devel
mailing list