<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, davidedmundson.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16095">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Previously it would use an on-disk <tt style="background: #ebebeb; font-size: 13px;">KImageCache</tt> which would never be invalidated. Moreover, it just uses <tt style="background: #ebebeb; font-size: 13px;">KIO::PreviewJob</tt> which does its own more clever (compares mtime and other properties) on-disk caching already.<br />
It's using its own <tt style="background: #ebebeb; font-size: 13px;">QCache</tt> rather than <tt style="background: #ebebeb; font-size: 13px;">QPixmapCache</tt> to not jeopardize other caching for the potentially large wallpaper thumbnails that are only relevant while the dialog iso pen.</p>

<p>BUG: 395447<br />
FIXED-IN: 5.15.0</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Scrolled through the list, had thumbnails be generated and cached</li>
<li class="remarkup-list-item">If there were too many some of them were discarded and this worked without crashing</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16095">https://phabricator.kde.org/D16095</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>wallpapers/image/CMakeLists.txt<br />
wallpapers/image/backgroundlistmodel.cpp<br />
wallpapers/image/backgroundlistmodel.h</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, davidedmundson<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>